|
From: | dak |
Subject: | Re: Fix clef transposition alignment (issue 3186) (issue 8363044) |
Date: | Sat, 16 Aug 2014 22:23:38 +0000 |
https://codereview.appspot.com/8363044/diff/6001/input/regression/clef-transposition-placement.ly File input/regression/clef-transposition-placement.ly (right): https://codereview.appspot.com/8363044/diff/6001/input/regression/clef-transposition-placement.ly#newcode21 input/regression/clef-transposition-placement.ly:21: \override Staff.Clef.full-size-change = ##t This syntax is not version 2.16.0 as declared above https://codereview.appspot.com/8363044/diff/6001/lily/clef-modifier.cc File lily/clef-modifier.cc (right): https://codereview.appspot.com/8363044/diff/6001/lily/clef-modifier.cc#newcode42 lily/clef-modifier.cc:42: me->get_property ("clef-alignments")); Up to this point there is not exactly a fabulous amount of crash-proneness in case of non-standard clef layout. The code does not seem particularly prepared to deal with a clef like varC. Why would the table clef-alignments be stored in a context property? It does not seem to be context dependent. https://codereview.appspot.com/8363044/
[Prev in Thread] | Current Thread | [Next in Thread] |