[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 3072: Nested overrides get confused with multiple contexts in
|
From: |
dak |
|
Subject: |
Re: Issue 3072: Nested overrides get confused with multiple contexts in play (issue 131770043 by address@hidden) |
|
Date: |
Sat, 16 Aug 2014 18:55:57 +0000 |
On 2014/08/16 18:36:50, lemzwerg wrote:
I don't actually understand the code, but I like the encapsulation,
so: LGTM.
Well, the encapsulation is actually issue 2507 (just presented here as
Patch Set 1 so that patchy will be able to test the patch on top). This
issue itself is Patch Set 2, so it's basically just
lily/context-property.cc, lily/include/context.hh and
lily/nested-property.cc. Which is nicely well-confined, but that's
because of issue 2507.
If you like the encapsulation, you like the patch for issue 2507. If
you like that nested properties will just work without handwaving and
ifs and buts, you like this issue.
The encapsulation means that it should be reasonably straightforward to
swap out the internals for something different again at some other point
of time if that's desirable.
https://codereview.appspot.com/131770043/