[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Removes outside-staff-priority from dynamic-related objects in Dynam
|
From: |
k-ohara5a5a |
|
Subject: |
Re: Removes outside-staff-priority from dynamic-related objects in Dynamic context (issue 7655045) |
|
Date: |
Sat, 30 Mar 2013 04:35:37 +0000 |
On 2013/03/27 21:50:02, janek wrote:
What was wrong with the skylines
that caused this bug? Maybe this is just one instance of a more
general problem.
The skylines themselves were fine, but objects above a Staff are not
checked for collisions with objects below a Staff.
In the example a Dynamics was serving as the staff, Dynamics has no
staff-lines but does have a conceptual reference line. The tempo mark
is placed above the Dynamics and the forte "f" below.
Usually, above-staff things go above the reference line and below-staff
things go below it, but DynamicLineSpanner had an override of its
Y-offset, centering it on the reference line. So adding the overrides
to make DynamicLineSpanner *not* outside the staff seems sensible.
Other above- or below-staff objects still have the usual Y-offset =
#side-position-interface::y-aligned-side putting them clearly on one
side or the other of the reference line, so the problem would not appear
for other objects
... until Mike changed side-position-interface::y-aligned-side() so that
now below-staff text scripts now sit on top of the Dynamics reference
line ?!
https://codereview.appspot.com/7655045/