[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Creates more possibilities for vertical and horizontal skyline funct
From: |
address@hidden |
Subject: |
Re: Creates more possibilities for vertical and horizontal skyline functions. (issue 7516048) |
Date: |
Tue, 19 Mar 2013 15:40:39 +0100 |
On 19 mars 2013, at 12:49, address@hidden wrote:
> Mike,
>
> i've read the patch 3 times and i don't understand how it solves the
> problem.
>
> I see that you remove some weird c++ code, but why can you do this?
> Also, why marking some grobs as cross-staff helps with solving issue
> 3242, which is about manual beams over rests?
> What figured bass has to do with this at all?
>
>> Creates more possibilities for vertical and horizontal skyline
> functions.
>
> I think this sentence applied to first version of the patch; it seems
> unrelated to current patchset.
>
> I'm sorry to say this, but i think this issue is unreviewable :/
Thanks for the feedback! I've changed the message on Rietveld to be more in
line with the current patch - you're right that it's bounced around quite a
bit. I've also added a couple comments.
Cheers,
MS