lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: checking 2240


From: Julien Rioux
Subject: Re: checking 2240
Date: Sun, 22 Jan 2012 15:07:46 -0500
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0) Gecko/20111222 Thunderbird/9.0.1

On 22/01/2012 3:00 PM, Janek Warchoł wrote:
2012/1/22 Graham Percival<address@hidden>:
why are you asking this question?  Is the source code really
*that* hard to read?  It's 18 lines!

Hey, i'm not a pro programmer.  There are so many brilliant
programmers here that my self-confidence is quite low; this is second
time i read Python and first time i read building scripts.  And i
don't want to do some stupid mistake, break Patchy and cause
unexpected damage to origin/staging and/or origin/master, which would
result in more problems that i'm trying to solve.

https://github.com/gperciva/lilypond-extra/blob/master/patches/compile_lilypond_test.py#L282

        for patch in patches:
            issue_id = patch[0]
            patch_filename = patch[1]
            title = patch[2]
            print "Trying %i with %s" % (issue_id, patch_filename)
            try:
                autoCompile.configure()
                autoCompile.patch(patch_filename)
                autoCompile.build(quick_make=True,
issue_id=issue_id)
                autoCompile.regtest_check(issue_id)
                autoCompile.copy_regtests(issue_id)
                autoCompile.make_regtest_show_script(issue_id,
title)
                # reverse stuff
                autoCompile.patch(patch_filename, reverse=True)
                autoCompile.regtest_clean(issue_id)
                autoCompile.clean(issue_id)
            except Exception as err:
                print "Problem with issue %i" % issue_id
                print err

Yes, i've read this 2 times.  If i didn't i wouldn't ask the question.

Janek.

_______________________________________________
lilypond-devel mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Hi Janek,
The autoCompile.patch part is defined here:
https://github.com/gperciva/lilypond-extra/blob/master/patches/compile_lilypond_test.py#L140

You'll see that the code uses
git apply filename.patch
and
git apply --reverse filename.patch

I think that is what you would like to modify following the suggestions on this thread.

Cheers,
Julien




reply via email to

[Prev in Thread] Current Thread [Next in Thread]