lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Let \footnote do the job of \footnote, \footnoteGrob, \autoFootnote


From: dak
Subject: Re: Let \footnote do the job of \footnote, \footnoteGrob, \autoFootnote and \autoFootnoteGrob (issue 5527058)
Date: Tue, 10 Jan 2012 10:19:54 +0000

On 2012/01/10 07:08:29, MikeSol wrote:
LGTM.  Good work!

The only think I'd ask is that you change the markup syntax before
pushing the
patch.  I think that, if the distinction between footnote and
auto-footnote is
going to be eliminated, it needs to be categorical.

Optional arguments are not implemented for markup functions, so no can
do.  It is an obvious contender once they are.  As a stopgap measure,
one might think about using ##f or something to that effect instead of
\default.  autoFootnote and auto-footnote have been different before, so
I don't consider it really urgent to squeeze this in while markup
functions have not received the treatment.

http://codereview.appspot.com/5527058/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]