[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Patch] Add support for tempo ranges (issue3248042)
From: |
Carl . D . Sorensen |
Subject: |
Re: [Patch] Add support for tempo ranges (issue3248042) |
Date: |
Wed, 24 Nov 2010 01:16:46 +0000 |
On 2010/11/24 00:28:37, Neil Puttock wrote:
The only thing I'm concerned about is the hybrid type; it's poorly
named:
`number-or-pair?' doesn't suggest a number-pair, but
`number-or-number-pair?' is
even worse.
I think using a list might a price worth paying to avoid creating a
new
predicate.
In my mind, it would be better to change the definition of
number-or-pair? to
(or (number? x) (pair? x))
I think this number-or-pair? would be sufficient for this case. It's
certainly as specific as a list? or cheap-list? check.
Thanks,
Carl
http://codereview.appspot.com/3248042/
- [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/22
- Re: [Patch] Add support for tempo ranges (issue3248042), Carl . D . Sorensen, 2010/11/22
- Re: [Patch] Add support for tempo ranges (issue3248042), reinhold . kainhofer, 2010/11/22
- Re: [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/22
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/23
- Re: [Patch] Add support for tempo ranges (issue3248042),
Carl . D . Sorensen <=
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/24
- Re: [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), Carl . D . Sorensen, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/25
- Re: [Patch] Add support for tempo ranges (issue3248042), n . puttock, 2010/11/26
- Re: [Patch] Add support for tempo ranges (issue3248042), v . villenave, 2010/11/26