lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Patch] Add support for tempo ranges (issue3248042)


From: Valentin Villenave
Subject: Re: [Patch] Add support for tempo ranges (issue3248042)
Date: Mon, 22 Nov 2010 19:05:55 +0100

On 2010/11/22 17:54:18, Carl wrote:
> Valentin,
>
> When the side-by-side diffs don't work, we can't publish comments on the 
> files.

Indeed.  That's unconvenient.

> There's an indentation error in scm/ly-syntax-constructors.scm, line 90.

Oh, indeed. I thought emacs would fix it, but it didn't.

> I'd prefer that we not define a new context property TempoRange.  Instead, I'd
> prefer that we define TempoCount to be either a number or a pair, and modify 
> the
> code that uses TempoCount so it can handle either one.

You're absolutely right. The reason why I did that was because I was
afraid some other code (e.g. performers) may rely on tempoUnitCount,
but I was wrong. I'll publish a new patch set shortly.

Thanks!

Valentin.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]