[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Remove arabic.ly from common note name languages. (issue2755041)
From: |
v . villenave |
Subject: |
Re: Remove arabic.ly from common note name languages. (issue2755041) |
Date: |
Wed, 27 Oct 2010 19:11:39 +0000 |
Thanks Trevor! New patch set.
http://codereview.appspot.com/2755041/diff/10001/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (left):
http://codereview.appspot.com/2755041/diff/10001/Documentation/notation/pitches.itely#oldcode579
Documentation/notation/pitches.itely:579: Many non-Western musics (and
some Western folk and
On 2010/10/27 17:41:18, Trevor Daniels wrote:
Other types of non-Western music
Er... no. Actually, These types music are not opposite to the former,
but even do include Arabic music! Please read again and tell me what I
could do to make it more clear...
http://codereview.appspot.com/2755041/diff/10001/Documentation/notation/pitches.itely#oldcode580
Documentation/notation/pitches.itely:580: traditional musics) employ
alternative or extended tuning
On 2010/10/27 17:41:18, Trevor Daniels wrote:
music
Done.
http://codereview.appspot.com/2755041/diff/10001/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):
http://codereview.appspot.com/2755041/diff/10001/Documentation/notation/pitches.itely#newcode590
Documentation/notation/pitches.itely:590: systems. Some of these
musics, like Arabic music, may
On 2010/10/27 17:41:18, Trevor Daniels wrote:
Some of these, like
Done.
http://codereview.appspot.com/2755041/diff/10001/Documentation/notation/pitches.itely#newcode593
Documentation/notation/pitches.itely:593: implicitely determined by
context. Other types of music,
On 2010/10/27 17:41:18, Trevor Daniels wrote:
implicitly ... Others, however
Done.
http://codereview.appspot.com/2755041/diff/10001/Documentation/notation/vocal.itely
File Documentation/notation/vocal.itely (right):
http://codereview.appspot.com/2755041/diff/10001/Documentation/notation/vocal.itely#newcode632
Documentation/notation/vocal.itely:632: Ky -- ri -- e __
On 2010/10/27 17:41:18, Trevor Daniels wrote:
Quite correct! But it shouldn't be part of this patch.
Oops, my git branches got messed up.
http://codereview.appspot.com/2755041/diff/10001/Documentation/notation/world.itely
File Documentation/notation/world.itely (right):
http://codereview.appspot.com/2755041/diff/10001/Documentation/notation/world.itely#newcode93
Documentation/notation/world.itely:93:
On 2010/10/27 17:41:18, Trevor Daniels wrote:
Music Glossary should come before Notation Reference
Are you sure? I thought that what should come first were links to the
same manual (i.e. @ref links).
http://codereview.appspot.com/2755041/diff/10001/Documentation/notation/world.itely#newcode261
Documentation/notation/world.itely:261: @notation{rast},
On 2010/10/27 17:41:18, Trevor Daniels wrote:
@rglos{ } ??
Indeed.
http://codereview.appspot.com/2755041/