[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Remove arabic.ly from common note name languages. (issue2755041)
From: |
Valentin Villenave |
Subject: |
Re: Remove arabic.ly from common note name languages. (issue2755041) |
Date: |
Wed, 27 Oct 2010 11:28:35 +0200 |
On Wed, Oct 27, 2010 at 8:58 AM, <address@hidden> wrote:
> I have reverted this commit.
For some reason, I wouldn't expect otherwise. :-)
> Calm the bloody mao down. Doc patches _do_ get approved. James Lowe
> has been steadily cleaning up broken documentation; his patches
> sometimes take a week and 3-4 versions (notwithstanding when I push one
> by accident), but he gets stuff done. Pushing a half-baked patch after
> only waiting 83 minutes for comments is *not* being fair to him and all
> the hard work he's been doing.
If it's half-baked, then please do comment on it.
If it's not, then you're just reverting things for the sake of reverting things.
> I'm sorry I was asleep when you sent the patch and didn't comment
> earlier, but we cannot rely on developers being awake and working on
> lilypond all the time. For your next patch, please wait at least 24
> hours before pushing, regardless of how positive the reviews are.
Whilst I understand the need to make it a matter of principles, if you
don't mind me asking: have you *looked* at the patch? It's a
three-sentences modification, for crying out loud! On a subject
(removing arabic.ly) that we already discussed at length, and where we
all agreed (AFAICR). Hadn't I ever heard anything from you on this
subject, then of course I wouldn't have dreamt of pushing this patch
without your blessing.
Now, you said you had some suggestions; I'm looking forward to hearing
about these.
Cheers,
Valentin.
- Remove arabic.ly from common note name languages. (issue2755041), v . villenave, 2010/10/26
- Re: Remove arabic.ly from common note name languages. (issue2755041), tdanielsmusic, 2010/10/26
- Re: Remove arabic.ly from common note name languages. (issue2755041), Carl . D . Sorensen, 2010/10/26
- Re: Remove arabic.ly from common note name languages. (issue2755041), v . villenave, 2010/10/26
- Re: Remove arabic.ly from common note name languages. (issue2755041), percival . music . ca, 2010/10/27
- Re: Remove arabic.ly from common note name languages. (issue2755041),
Valentin Villenave <=
- Re: Remove arabic.ly from common note name languages. (issue2755041), v . villenave, 2010/10/27
- Re: Remove arabic.ly from common note name languages. (issue2755041), tdanielsmusic, 2010/10/27
- Re: Remove arabic.ly from common note name languages. (issue2755041), v . villenave, 2010/10/27