Re: Implement framework for post-fix text (de)cresc spanners

[Reinhold Kainhofer]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Samstag, 22. August 2009 19:19:18 schrieb Han-Wen Nienhuys:
> brief comments:
>
> - get_property_setting() should take SCMs rather than const char* , so
> you save runtime lookups.

I don't exactly understand what you mean by this... The two parameters of 
get_property_setting are passed on the get_property, which call 
internal_get_property (symbol2scm (...)) on them. Of course, I could do the 
symbol2scm before calling get_property_setting and then call 
internal_get_property there, but I don't see how this will save anything (in 
particular, since the context property names will be dynamically built from 
the start_type: (start_type + "Text").c_str ()

The only thing that might be optimized is the fixed-name event properties. But 
that saves one symbol2scm call for hairpins and two for text crescendi. Is 
this really worth the trouble of handling the two property names differently to 
save on symbol2scm call?

Cheers,
Reinhold

- -- 
- ------------------------------------------------------------------
Reinhold Kainhofer, address@hidden, http://reinhold.kainhofer.com/
 * Financial & Actuarial Math., Vienna Univ. of Technology, Austria
 * http://www.fam.tuwien.ac.at/, DVR: 0005886
 * LilyPond, Music typesetting, http://www.lilypond.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQFKl7GQTqjEwhXvPN0RAgPxAJ4iduCC6mqqxSjSF/91Kt+vLulF/QCgkVVD
I+LvGekkcHIGVtfCatzNcl4=
=pG2z
-----END PGP SIGNATURE-----