lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: MusicXML patch


From: Reinhold Kainhofer
Subject: Re: MusicXML patch
Date: Thu, 31 Jan 2008 17:10:09 +0100
User-agent: KMail/1.9.7

Am Donnerstag, 31. Januar 2008 schrieb Erlend Aasland:
> Since you've done most of the MusicXML stuff lately, could you please
> review the attached patch. I'll apply it if you approve it.

Thanks for the patches. 
I don't see any problems with the patch.
Can you maybe add a unit test for unpitched and for the graces with missing 
type to input/regression/musicxml and check that your changes don't break 
tests 13a and 13b (see 
http://kainhofer.com/~lilypond/input/regression/musicxml/collated-files.html)?

Cheers,
Reinhold



-- 
------------------------------------------------------------------
Reinhold Kainhofer, Vienna University of Technology, Austria
email: address@hidden, http://reinhold.kainhofer.com/
 * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/
 * K Desktop Environment, http://www.kde.org, KOrganizer maintainer
 * Chorvereinigung "Jung-Wien", http://www.jung-wien.at/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]