[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Edit comments?

From: Noel L Yap
Subject: Re: Edit comments?
Date: Sun, 15 Oct 2000 08:16:15 -0400

I can easily see some people wanting the edit comment appended to the checkin
comment.  Maybe this should be an option?  Which behaviour should be the

Does anyone volunteer to code this up?  I can lend some assistance in where to
make code changes, but I don't have time to make them.


address@hidden on 2000.10.13 16:28:37

To:   address@hidden, address@hidden
cc:   address@hidden, address@hidden
Subject:  Re: Edit comments?

Fair enough.  How about this?

- Blank commit message in the editor when it comes up.
- Output of editor becomes commit message, if modified by user.
- "cvs edit" message becomes the commit message when the edited file is
  unchanged (or empty) or an empty -m option is given.
- Non-empty -m option takes precedence over "cvs edit" message during commit.

Note that the default messages remain one-per-file, but replacements (via
editor or command line) are one-per-command.

--- Forwarded mail from address@hidden

The problem here is that edit comments are one-per-file while checkin comments
are one-per-command-line (or one-per-directory when using local CVS).

address@hidden on 2000.10.13 12:52:44

I would expect the edit comment to be the default commit message:

- It appears in the editor when it comes up.
- It becomes the commit message when given an empty -m option.
- It is overridden by a non-empty -m option.

--- Forwarded mail from address@hidden

I had thought a little about this at one point.  IIRC, this would involve no
more than adding an extra subfield in fileattr and extending the protocol a
little.  I don't think this is that much work since the protocol can be extended
easily without breaking older clients/servers (but you may not have the new
feature if you use older clients/servers).

One thing to ensure is that special characters in the new subfield must be
escaped properly.

Using the comments for checkin may need some more thought.  For example, will
the edit comments be appended to the checkin comments or will they replace
checkin comments?

--- End of forwarded message from address@hidden

--- End of forwarded message from address@hidden

This communication is for informational purposes only.  It is not intended as
an offer or solicitation for the purchase or sale of any financial instrument
or as an official confirmation of any transaction. All market prices, data
and other information are not warranted as to completeness or accuracy and
are subject to change without notice. Any comments or statements made herein
do not necessarily reflect those of J.P. Morgan & Co. Incorporated, its
subsidiaries and affiliates.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]