[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: cvs commit confusing behaviour on modified files without changed

From: Larry Jones
Subject: Re: cvs commit confusing behaviour on modified files without changed
Date: Wed, 4 Oct 2000 11:02:30 -0400 (EDT)

Derek R. Price writes:
> Olivier Berger wrote:
> > If i issue a cvs commit command, cvs will ask for a commit log message,
> > displaying a pre-filled editor with the file marked as modified.
> >
> > But as I save the message and exit the editor, nothing gets committed.
> >
> > As cvs has connected to the server, it detects that the content hasn't
> > changed, and doesn't commit anything without notifying me.
> >
> > So everything looks like the commit aborted for some unreported reason.
> This is standard client/server behavior and is still present in CVS 1.11.

That's true.

> I believe it has to do with CVS's policy of minimizing network transfer.
> This way CVS is both only opening a single connection to the server and
> not leaving a connection open while a user fills out a log message.  I
> personally have been viewing this as a bug but there are several issues
> involved and I haven't come up with an appropriate fix yet.

That's not -- CVS *does* leave a connection open while the user fills
out the log message (it doesn't want to have the user spend lots of time
creating a really good log message if it can't contact the server).  The
problem is that the server is the only one who can tell whether a file
was actually modified or not and there's no provision in the client/
server protocol for the server to communicate that information back to
the client to let the client change its behavior.  In fact, the current
implementation sends the log message to the server before it sends the
files, so it would be too late even if there were.  I suppose you can
consider this a bug, although it's a very innocuous one.

If you do an update before the commit (which is always a good idea
anyway), it will allow the client to determine which of the potentially
changed files are actually changed and avoid the disconcerting behavior.

-Larry Jones

That's the problem with nature.  Something's always stinging you
or oozing mucus on you. -- Calvin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]