guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 01/01: guix: Simplify and robustify lzread!.


From: Ludovic Courtès
Subject: Re: 01/01: guix: Simplify and robustify lzread!.
Date: Fri, 10 May 2019 23:40:50 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)

Heya,

Pierre Neidhardt <address@hidden> skribis:

>>>>>     guix: Simplify and robustify lzread!.
>>>>       ^
>>>> Should be lzlib.
>>>
>>> Oops!
>>> I must confess that I never really understood the whole logic behind
>>> GNU-style commit message :p
>>
>> It’s really Guix-specific here, but the idea is that the word before
>> colon indicates the part of the code being modified, to provide a bit of
>> context.
>
> That makes sense.  Where it makes less sense to me is when we prefix
> with "gnu:" for packages.  Why GNU?  Why not "packages:"?

Historical reasons.  :-)  Once upon a time that was “distro:”…

> No bug on an actual use case.  I kept discussing with Antonio and he
> pointed out the potential issue.  The solution occurred to me on a fresh
> sunny morning :D

Good.  :-)

>> (I’m super cautious here but that’s because I spent countless hours
>> debugging code that used zlib and libbz2 and lzo in the past.  :-))
>
> Yup, tell me about it...  Took me weeks just to figure out basic
> (de)compression ;)
>
> But now that I have a better understanding of the library, I'm much more
> confident about the robustness and debugability of the bindings.  Once
> things start adding up in your head, it's much more straightforward to
> see what goes wrong and how to fix it.  (Stating the obvious here, but
> that's only true with good libraries, and lzlib is a good one.)

Alright, sounds good!

Thank you,
Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]