Re: [PATCH 2/2] services: Add openvswitch-service-type.

[Ludovic Courtès]

宋文武 <address@hidden> skribis:

> * gnu/services/networking.scm (<openvswitch-configuration>): New record type.
> (openvswitch-activation, openvswitch-shepherd-service): New procedures.
> (openvswitch-service-type): New variable.
> * doc/guix.texi (Networking Services): Document it.

[...]

> address@hidden {Data Type} openvswitch-configuration
> +Data type representing the configuration of openvswitch.

s/openvswitch/Open vSwitch, the blah blah networking blah/

> +       #~(begin
> +           (use-modules (guix build utils))

Better with:

  (with-imported-modules '((guix build utils))
    #~(begin
        (use-modules (guix build utils))
        …))

> +         (start #~(make-forkexec-constructor
> +                   (list #$ovsdb-server
> +                         "--remote=punix:/var/run/openvswitch/db.sock")))

If it produces a PID file, use #:pid-file here.

OK with these changes, thanks!

Ludo’.