[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] gnu: Add openvswitch.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH 1/2] gnu: Add openvswitch. |
Date: |
Sun, 29 Jan 2017 00:56:06 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Hi 宋文武!
宋文武 <address@hidden> skribis:
> * gnu/packages/networking.scm (openvswitch): New variable.
[...]
> + '(;; FIXME: many tests fail with:
> + ;; […]
> + ;; test -e $OVS_RUNDIR/ovs-vswitchd.pid
> + ;; ovs-appctl -t ovs-vswitchd exit
> + ;; hard failure
> + #:tests? #f
Can we assume that the failures are due to the lack of a proper
networking environment? Do they pass outside of the chroot?
It would be good to have a rough idea of why they fail.
> + (replace 'install
> + (lambda _
> + (zero? (system* "make"
> + "RUNDIR=/tmp"
> + "PKIDIR=/tmp"
> + "LOGDIR=/tmp"
> + "DBDIR=/tmp"
> + "install")))))))
I suppose this is to prevent “mkdir /var/log” or similar, right?
Perhaps worth mentioning in a comment.
The rest LGTM.
Thanks!
Ludo’.