[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix.
From: |
Eric Bavier |
Subject: |
Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix. |
Date: |
Tue, 16 Aug 2016 17:38:03 -0500 |
On Tue, 16 Aug 2016 23:15:07 +0300
Alex Kost <address@hidden> wrote:
> David Craven (2016-08-16 21:39 +0300) wrote:
>
> > * gnu/packages/gstreamer.scm (define-module): Import guix licenses with
> > #:prefix
> > license:.
> > (orc): Likewise.
> > (gstreamer): Likewise.
> > (gst-plugins-base): Likewise.
> > (gst-plugins-good): Likewise.
> > (gst-plugins-bad): Likewise.
> > (gst-plugins-ugly): Likewise.
> > (gst-libav): Likewise.
> > (python-gst): Likewise.
> ^^
> Please remove the leading spaces before "(...): Likewise."
In fact, I think this is a case where one could simple say something
like "Adjust license references".
> I like this patch. However in general (a question for Guix people): is
> there a reason to use #:select for licenses? Or would it be better to
> use #:prefix everywhere? If the latter (my preference), I think it
> would be good to make this "#:select"→"#:prefix" change in a single
> patch instead of making separate patches for different modules.
I don't think it's something that needs to be mandated. If we were to
use '#:prefix license:' everywhere, we might as well save the trouble
and just rename everything in (guix license) with the
prefix. But I don't think this is necessary. There are instances of
importing with '#:hide' even, which I think has its place.
`~Eric
- Re: [PATCH 16/24] gnu: gstreamer: Add qt-gstreamer., (continued)
- [PATCH 19/24] gnu: fritzing: Use modular qt., David Craven, 2016/08/16
- [PATCH 20/24] gnu: bitcoin-core: Use modular qt., David Craven, 2016/08/16
- [PATCH 11/24] gnu: modemmanager-qt: Propagate modem-manager., David Craven, 2016/08/16
- [PATCH 14/24] gnu: gstreamer: Use license: prefix., David Craven, 2016/08/16
- Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix., Danny Milosavljevic, 2016/08/16
- Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix., Alex Kost, 2016/08/16
- Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix., David Craven, 2016/08/16
- Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix.,
Eric Bavier <=
- Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix., David Craven, 2016/08/17
- Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix., Danny Milosavljevic, 2016/08/17
- Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix., David Craven, 2016/08/17
- Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix., Danny Milosavljevic, 2016/08/17
- Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix., David Craven, 2016/08/17
[PATCH 22/24] gnu: poppler-qt5: Use modular qt., David Craven, 2016/08/16
[PATCH 21/24] gnu: gst-plugins-bad: Use modular qt., David Craven, 2016/08/16
[PATCH 18/24] gnu: qsynth: Use modular qt., David Craven, 2016/08/16