[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix.
From: |
David Craven |
Subject: |
Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix. |
Date: |
Tue, 16 Aug 2016 22:29:46 +0200 |
> I like this patch. However in general (a question for Guix people): is
> there a reason to use #:select for licenses? Or would it be better to
> use #:prefix everywhere? If the latter (my preference), I think it
> would be good to make this "#:select"→"#:prefix" change in a single
> patch instead of making separate patches for different modules.
I think that #:select has it's purpose. It helps increase readability when
one or two things are selected for example in bootstrap.scm.
#:use-module ((guix store) #:select (add-to-store add-text-to-store))
#:use-module ((guix derivations) #:select (derivation))
#:use-module ((guix utils) #:select (gnu-triplet->nix-system))
However when it comes to licenses it's verbose and unnecessary. I'll
amend the commit tomorrow to cover all cases where #:select is used
for importing licenses.
- Re: [PATCH 16/24] gnu: gstreamer: Add qt-gstreamer., (continued)
- [PATCH 19/24] gnu: fritzing: Use modular qt., David Craven, 2016/08/16
- [PATCH 20/24] gnu: bitcoin-core: Use modular qt., David Craven, 2016/08/16
- [PATCH 11/24] gnu: modemmanager-qt: Propagate modem-manager., David Craven, 2016/08/16
- [PATCH 14/24] gnu: gstreamer: Use license: prefix., David Craven, 2016/08/16
- Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix., Danny Milosavljevic, 2016/08/16
- Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix., Alex Kost, 2016/08/16
- Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix.,
David Craven <=
- Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix., Eric Bavier, 2016/08/16
- Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix., David Craven, 2016/08/17
- Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix., Danny Milosavljevic, 2016/08/17
- Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix., David Craven, 2016/08/17
- Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix., Danny Milosavljevic, 2016/08/17
- Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix., David Craven, 2016/08/17
[PATCH 22/24] gnu: poppler-qt5: Use modular qt., David Craven, 2016/08/16
[PATCH 21/24] gnu: gst-plugins-bad: Use modular qt., David Craven, 2016/08/16