Re: [PATCH 00/17] Emacs packages!

[Ricardo Wurmus]

Alex Kost <address@hidden> writes:

> Ricardo Wurmus (2016-07-13 00:04 +0300) wrote:
>
>> Hi Guix,
>>
>> here are almost all of the remaining Emacs packages that I previously
>> installed via package.el.  I hope you find them useful!
>>
>> ~~ Ricardo
>>
>> Ricardo Wurmus (17):
>>   gnu: Add emacs-el-mock.
>>   gnu: Add emacs-espuds.
>>   gnu: Add emacs-expand-region.
>>   gnu: Add emacs-fill-column-indicator.
>>   gnu: Add emacs-znc.
>>   gnu: Add emacs-paren-face.
>>   gnu: Add emacs-page-break-lines.
>>   gnu: Add emacs-simple-httpd.
>>   gnu: Add emacs-skewer-mode.
>>   gnu: Add emacs-rich-minority.
>>   gnu: Add emacs-smart-mode-line.
>>   gnu: Add emacs-shut-up.
>>   gnu: Add emacs-undercover.
>>   gnu: Add emacs-shell-switcher.
>>   gnu: Add emacs-tagedit.
>>   gnu: Add emacs-perspective.
>>   gnu: Add emacs-solarized-theme.
>
> Overall, the packages look good to me, thanks!
>
> My main question is about adding to inputs libraries that are not needed
> for the packages themselves, as I wrote in the replies.

Thank you for the review.

I added inputs that are needed for the tests mostly because I didn’t
understand the error messages or warnings during the build phase.  I
wanted to avoid skipped files in the compilation process, so I added all
these development inputs like “espuds”.

It’s good to know I may leave them off.  Thanks for the helpful
comments.  I’ll update the patches and push them.

~~ Ricardo