Re: [PATCH 17/17] gnu: Add emacs-solarized-theme.

[Roel Janssen]

Ricardo Wurmus writes:

> Roel Janssen <address@hidden> writes:
>
>> Ricardo Wurmus writes:
>>
>>> * gnu/packages/emacs.scm (emacs-solarized-theme): New variable.
>>> ---
>>>  gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
>>>  1 file changed, 24 insertions(+)
>>>
>>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>>> index 2c92756..4f2d5ca 100644
>>> --- a/gnu/packages/emacs.scm
>>> +++ b/gnu/packages/emacs.scm
>>> @@ -2086,6 +2086,30 @@ number.")
>>>  It is built on top of the custom theme support in Emacs 24 or later.")
>>>      (license license:gpl3+)))
>>>  
>>> +(define-public emacs-solarized-theme
>>> +  (package
>>> +    (name "emacs-solarized-theme")
>>> +    (version "1.2.2")
>>> +    (source (origin
>>> +              (method url-fetch)
>>> +              (uri (string-append 
>>> "https://github.com/bbatsov/solarized-emacs/";
>>> +                                  "archive/v"  version ".tar.gz"))
>>> +              (file-name (string-append name "-" version ".tar.gz"))
>>> +              (sha256
>>> +               (base32
>>> +                "1ha3slc6d9wi9ilkhmwrzkvf308n6ph7b0k69pk369s9304awxzx"))))
>>> +    (build-system emacs-build-system)
>>> +    (propagated-inputs
>>> +     `(("emacs-dash" ,emacs-dash)
>>> +       ("emacs-f" ,emacs-f)
>>> +       ("emacs-s" ,emacs-s)))
>>> +    (home-page "http://github.com/bbatsov/solarized-emacs";)
>>> +    (synopsis "Port of the Solarized theme for Emacs")
>>> +    (description
>>> +     "Solarized for Emacs is a port of the Solarized theme for Vim.  This
>>> +package provides a light and a dark variant.")
>>> +    (license license:gpl3+)))
>>> +
>>>  (define-public emacs-smartparens
>>>    (package
>>>      (name "emacs-smartparens")
>>
>> After installing this package I tried to `M-x load-theme solarized'.  That
>> resulted in the error: `Undefined Custom theme solarized'.
>>
>> However, `solarized-dark' works fine.
>>
>> Could you verify that `M-x load-theme solarized' works on your end?
>
> I’m using “solarized-light” only.  Is “M-x load-theme solarized”
> even supposed to work?

The auto-completion shows three themes: solarized, solarized-light, and
solarized-dark.  The description says this package provides two themes:
light and dark.

I guess it works as it is supposed to, because the description tells
there are two variants.

So, the patch is fine with me.

Kind regards,
Roel Janssen