Re: [PATCH 1/7] gnu: Add mate-polkit.

[Andreas Enge]

Hello,

On Sat, Feb 20, 2016 at 06:17:28PM +0100, Fabian Harfert wrote:
> I carefully checked all the library source dependencies and so on. I
> think all these propagated inputs are needed.

okay, excellent.

> If that is necessary, I'll add these comments, but I think it's not too
> difficult to look into the .pc files. Some of the packages have
> comments, but the most don't.

Well, it would be useful in the future, as some kind of proof that you had
a look at it, and also to keep track if people wonder why it has been
done like this. If there is a change in the future and something is not
needed any more, this would then become clear simply by looking at the
referenced .pc file.

> But actually I don't really know. I'll recheck all the .pc files and
> headers (not too much).

I think there is no need to check the headers; the example I gave was
already treated correctly. If a header is needed, most of the time the
library will also be mentioned in the .pc file.

I will let you have a look at the glib-or-gtk-build-system question,
and give us notice again when the next patches are ready. On the other
hand, if there are mistakes, that would not be a big problem; when you
notice in the end that something does not work, it will still be time
to add (propagated or other) inputs.

Thanks for all this work!

Andreas