Re: [PATCH 1/7] gnu: Add mate-polkit.

[Fabian Harfert]

Hello,

thanks for your reply.

On Sat, 20 Feb 2016 14:41:17 +0100
Andreas Enge <address@hidden> wrote:

> Hello,
> 
> before considering more mate packages, I would like to get back to
> discussing the existing ones; as I am not knowledgeable about desktop
> packages, I must admit I did not look at them too closely before. So
> maybe my comments can also be disregarded, but it would be good if
> someone more expert could chime in.
> 
> First of all, the build system. Since usually there are inputs glib
> and gtk+, would it not be more appropriate to use
> glib-or-gtk-build-system?

I thought, as the normal GNU build system is used here, I'll use that.
But reading the documentation again, I've found out, that what you
mentioned is a good idea. I'll change this.

> Second, there are lots of propagated inputs. Are these really needed?

I carefully checked all the library source dependencies and so on. I
think all these propagated inputs are needed.

> It is a bit strange that a library like libmateweather should need
> such a propagation; normally our runpath magic should have rewritten
> all references to input libraries.
> 
> If propagations are necessary, the reason should be added as a
> comment, for instance as for gnome-desktop:
>     (propagated-inputs
>      ;; Required by gnome-desktop-3.0.pc.
>      `(("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
>        ("gtk+" ,gtk+)))

If that is necessary, I'll add these comments, but I think it's not too
difficult to look into the .pc files. Some of the packages have
comments, but the most don't.

> The .pc file of libmateweather indeed has the following lines:
>    Requires: glib-2.0 gobject-2.0 gdk-pixbuf-2.0 gtk+-2.0 gio-2.0
>    Requires.private: libxml-2.0 libsoup-2.4
> Also, weather.h contains
>    #include <gdk-pixbuf/gdk-pixbuf.h>
> So it looks as if propagation is needed here.

I also saw that, but I thought, if the .pc file isn't referring to
something, it doesn't make sense to add it, because pkg-config
won't add the necessary compiler flags and libraries, so that gcc isn't
finding it.

But actually I don't really know. I'll recheck all the .pc files and
headers (not too much).

> 
> What do you think?
> 
> Andreas
>

In general I think you should wait until I've ready the rest of MATE
(caja, mate-control-center and stuff like documentation or wallpapers),
so that it can be tested by me first. The patches I've sent were more
for corrections and review.

So thanks for the hints!

Fabian