Re: [PATCH 2/3] gnu: Don't use guix build utils

[Leo Famulari]

On Wed, Feb 17, 2016 at 06:28:18PM +0000, Christopher Baines wrote:
> On 13/02/16 22:39, Leo Famulari wrote:
> > On Sat, Feb 13, 2016 at 04:07:54PM +0000, Christopher Baines wrote:
> >> As this provides a which procedure which conflicts with the which package
> >> provided by gnu packages base.
> >>
> >> * gnu/packages/version-control.scm (version-control): Don't use utils
> > 
> > I can build all the packages in version-control.scm with this change,
> > but I don't fully understand its implications so I'll wait for another
> > reviewer to weigh in.
> 
> Andreas has now commented on this in response to the third patch.
> 
> > If it's okay, I will squash this commit into "Add vcsh", since that
> > commit is broken without this one.
> 
> This does not make much sense to me, as they are separate changes, and
> when applied in the right sequence, everything will work (but it really
> depends what workflow you are using with Git).

The commit that removes the module only makes sense in the context of
adding vcsh. It's analogous to adding a module that is required for a
new package, and that is done in a single commit. So, I think it's
better to squash the commits.