guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] gnu: Add vcsh


From: Andreas Enge
Subject: Re: [PATCH 3/3] gnu: Add vcsh
Date: Wed, 17 Feb 2016 19:11:07 +0100
User-agent: Mutt/1.5.24 (2015-08-30)

Hello,

this looks good. I also added a copyright line for you.

On Sun, Feb 14, 2016 at 08:36:00PM +0000, Christopher Baines wrote:
> +     "vcsh provides the @code{vcsh} command, which allows you to maintain

I would shorten to "vcsh allows ..."; that vcsh provides the vcsh command
is close to a tautology.

> +the separation of the files in to different repositories, for example you

"in to" -> "into".

The build depends on perl-shell-command, which is not yet in the distribution;
so it looks like another patch should go in first. Leo, I think you handled
these? Could you have another look? Concerning one of your questions, I think
that removing "guix build utils" from the imported modules is fine (actually,
it was me who recommended it...).

Andreas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]