Re: [PATCHES] Update orfm and package test requirements.

[Ben Woodcroft]

Hi,

I've been a little while responding as I intending on releasing a new 
OrfM version before bothering you again. I'd push all this myself but 
wanted to check one last thing so I don't sound too enthusiastic about 
my own software.
> > +
> > +(define-public ruby-bio-commandeer
> > +  (package
> > +    (name "ruby-bio-commandeer")
> > +    (version "0.1.2")
> > +    (source
> > +     (origin
> > +       (method url-fetch)
> > +       (uri (rubygems-uri "bio-commandeer" version))
> > +       (sha256
> > +        (base32
> > +         "061jxa6km92qfwzl058r2gp8gfcsbyr7m643nw1pxvmjdswaf6ly"))))
> > +    (build-system ruby-build-system)
> > +    (arguments
> > +     `(#:phases
> > +       (modify-phases %standard-phases
> > +         (replace 'check
> > +           ;; Run test without calling 'rake' so that jeweler is
> > +           ;; not required as an input.
> > +           (lambda _
> > +             (zero? (system* "rspec" "spec/bio-commandeer_spec.rb")))))))
> > +    (propagated-inputs
> > +     `(("ruby-bio-logger" ,ruby-bio-logger)
> > +       ("ruby-systemu" ,ruby-systemu)))
> > +    (native-inputs
> > +     `(("bundler" ,bundler)
> > +       ("ruby-rspec" ,ruby-rspec)))
> > +    (synopsis "Simplified running of shell commands from within Ruby")
> > +    (description
> > +     "Bio-commandeer is a dead simple opinionated method of running shell
> > +commands from within Ruby.  The advantage of bio-commandeer over other methods
> > +of running external commands is that when something goes wrong, the error
> > +message that is reported gives extra detail to ease debugging.")
> I don’t really like the first sentence.  How about
>
>     “Bio-comandeer lets you run shell commands from within Ruby.  ...”
That wasn't the best sentence before, fo so. I wonder if the replacement 
is a little bland though. How about (as attached),

+     "Bio-commandeer provides an opinionated method of running shell 
commands
+from within Ruby.  The advantage of bio-commandeer over other methods of
+running external commands is that when something goes wrong, the 
@code{STDOUT}
+and @code{STDERR} are reported, giving extra detail to ease debugging.")

OK? I made scattered other changes too on top of accepting your 
suggestions, but I don't imagine a full re-review is necessary.
Thanks for the review.
ben

0003-gnu-orfm-Update-to-0.5.3.patch
Description: Text Data

0002-gnu-Add-ruby-bio-commandeer.patch
Description: Text Data

0001-gnu-Add-ruby-systemu.patch
Description: Text Data