guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCHES] Update orfm and package test requirements.


From: Ben Woodcroft
Subject: Re: [PATCHES] Update orfm and package test requirements.
Date: Thu, 14 Jan 2016 08:05:58 +1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0



On 13/01/16 23:50, Ricardo Wurmus wrote:
Ben Woodcroft <address@hidden> writes:


[..]
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'patch-and-set-version
+           (lambda _
+             (setenv "VERSION" ,version)
+             #t)))))
That’s an odd phase name; why “patch”?  Is setting the environment
variable the only way to set the version or would a make-flag work here,
too?  (I haven’t checked if the ruby-build-system respects make-flags.)

The rest looks good to me.  Thanks!
Pushed, thanks. The phase name above was a bit crufty so I changed it, but had to go with setenv since the ruby-build-system doesn't support make-flags (or rake-flags).

Thanks,
ben



reply via email to

[Prev in Thread] Current Thread [Next in Thread]