[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [v3 1/2] gnu: w3m: Update patch to use '-p1'.
From: |
Ludovic Courtès |
Subject: |
Re: [v3 1/2] gnu: w3m: Update patch to use '-p1'. |
Date: |
Wed, 06 Jan 2016 11:33:28 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Leo Famulari <address@hidden> skribis:
> * gnu/packages/patches/w3m-fix-compile.patch: Update to work with -p1.
> * gnu/packages/w3m.scm (w3m): Drop patch flag -p0.
I would rename the patch to, say, ‘w3m-libgc.patch’, for clarity.
> --- a/gnu/packages/patches/w3m-fix-compile.patch
> +++ b/gnu/packages/patches/w3m-fix-compile.patch
> @@ -1,15 +1,27 @@
> +From 371f256f5f300b01be228a6fd95884ea475965fc Mon Sep 17 00:00:00 2001
> +From: Leo Famulari <address@hidden>
> +Date: Tue, 5 Jan 2016 16:57:29 -0500
> +Subject: [PATCH 1/4] fix compile
> +
> https://bugs.archlinux.org/task/33397
Could you remove the Git header and write something like:
This patch fixes w3m compilation with libgc > X.Y.
(If I understand correctly what it does.)
However, I’m surprised this is needed since libgc hasn’t changed lately?
Thanks,
Ludo’.