Re: [PATCH] Fix broken handling of non-ASCII strings

[David Pirotte]

Hello Mark,

Le Thu, 23 Jun 2011 14:21:22 -0400,
Mark H Weaver <address@hidden> a écrit :

> David Pirotte <address@hidden> writes:
> > I kind of remember, at some point in the discussion related to this
> > mater and you 'welcome as a guile-gnome' developer/maintainer that you
> > would apply these important patches to the main tree.
> 
> Thanks for the reminder.  Unfortunately my patch breaks compatibility
> with Guile 1.8, which does not provide a function to convert strings to
> UTF-8.  We'll need to add an autoconf check for scm_to_utf8_stringn, and
> add a compatibility shim if it's not available.

Ok. How about creating another branch 'right now':

        -]      keep 'the old one' in case needed for support to
                guile-gnome-platform under guile-1.8;

        -]      create a new branch and 'go forward' with what is needed
                without to have to 'bother' with backward compatibility ?

What do you think ?

> There's nothing very difficult here, but a few issues have conspired to
> cause procrastination on my part:
> 
> * I've never hacked autoconf, so I'll need to educate myself.
> 
> * I've never worked with Guile 1.8, and testing the new patch will
>   require me to build gnome-guile against Guile 1.8, to make sure it
>   doesn't break anything.
> 
> * I'm uncomfortable with guile-gnome's weird "modules as branches"
>   repository structure, especially given that this patch changes
>   multiple modules.  I must have confidence in my understanding of how
>   this works before pushing the changes.
> 
>      Mark

I understand.

Thanks,
David