Re: [PATCH] Fix broken handling of non-ASCII strings

[David Pirotte]

Hello Mark,

I kind of remember, at some point in the discussion related to this mater and 
you
'welcome as a guile-gnome' developer/maintainer that you would apply these 
important
patches to the main tree.

Well just to inform you that early in May I did take a git clone / installed
guile-gnome-platform on another machine and the patches were not 'part' of ... I
think it would be nice to apply them.

Thanks,
David

;; --

Le Tue, 19 Apr 2011 23:27:24 -0400,
Mark H Weaver <address@hidden> a écrit :

> Hello all,
> 
> David Pirotte <address@hidden> reported on #guile that
> gtk-text-buffer-set-text dropped the last character of the provided
> string if it contained a latin-1 character.  More generally, it fails if
> any non-ASCII characters are present.
> 
> Upon investigation, I discovered that whereas the GTK interfaces
> generally expect a UTF-8 encoded string and a length in _bytes_,
> guile-gnome is instead passing a locale-encoded string and a length in
> _characters_.
> 
> The attached patches fix this problem in only a few places related to
> GTK Text widgets.  I'm reasonably sure that there are _many_ other
> similar bugs.  The vast majority of uses of scm_from_locale_* and
> scm_to_locale_*, both in guile-gnome and in guile itself, are erroneous.
> 
> If someone else would be willing to fix the rest of these bugs in
> guile-gnome, it would be most appreciated.  I'd prefer to concentrate on
> guile core for now.
> 
>     Best,
>      Mark