[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Re: Bug in read_handler_list (autoloading) ???
From: |
Robert Millan |
Subject: |
Re: [PATCH] Re: Bug in read_handler_list (autoloading) ??? |
Date: |
Thu, 12 Nov 2009 21:51:09 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Nice work.
On Thu, Nov 12, 2009 at 09:36:34PM +0100, Felix Zielcke wrote:
> /* Override previous handler.lst. */
> - while (grub_handler_class_list)
> + for (; hc ; hc = hcnext)
> {
> - grub_handler_class_t tmp;
> - tmp = grub_handler_class_list->next;
> - grub_free (grub_handler_class_list);
> - grub_handler_class_list = tmp;
> + hcnext = hc->next;
> + hl = hc->handler_list;
> + while (hl)
> + {
> + grub_handler_t tmp = hl->next;
> + if (grub_strcmp (hl->name, "rescue") != 0
> + && grub_strcmp (hl->name, "console") != 0)
Could you add a comment here explaining why these are skipped?
The rest is OK as far as I'm concerned.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."