Re: [gpsd-dev] Where to put tests for: $GPVTG

[Gary E. Miller]

Yo teyrana!

On Sat, 28 Apr 2018 17:25:31 -0400
teyrana <address@hidden> wrote:

> Two pretty quick questions for you:
> 
> 1. Where should I put tests for verifying VTG message processing?

Use the built in regression scheme.  Add a GPS capture file in
tests/daemon that has the VTG commands.

>   a) modify every device-specific test case which contains VTG
> messages? b) emplace a specific test somewhere else, that's not
> obvious to me...

Nope just add a new test file.

> 1. I see $GPVTG messages already sprinkled throughout several device
> tests:  (36 of the .log files in `test/daemon` of them, to be exact)
> but it doesn't look like they're interpreted in any of them?
>   e.g.
> https://github.com/teyrana/gpsd/blob/9429b1a5498e0e1ea68d5e53245c897dda52e5aa/test/daemon/bn-9015.log.chk#L65

Easy to find out.  When VTG code gets added to gpsd, then 'scons check'
will run all those sample files, and any new output data will show up
as errors.  We validate the errors are really good new data, then
update the expected test output data to match.

Easier than it sounds.

> 2. I also looked at the test_*.c files, but they don't seem to
> contain many of the tests themselves:
>   - `test_packet.c` only sees to test *parsing* of the raw nmea.
>   - `test_libpgs.c` seems to be the test-file-runner (?)

Yeah, ignore those.

> 2. I notice you guys also don't have a test *.log.chk for our brand
> (Hemisphere). Would it be worth while to add it?

Yup, more tests the better. Put the new raw data in tests/daemon, then
use regres-driver -b to create the new check file.

> (Our receiver: for reference:
> https://hemispheregnss.com/Products/Products/Position-Heading/vector-v103e284a2-and-v113e284a2-gps-compasses-96

Look in gpscap.ini, add your GPS to it.

Then send patches.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        address@hidden  Tel:+1 541 382 8588

            Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin

pgppMxkqzStPd.pgp
Description: OpenPGP digital signature