gnulib-tool-py
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gnulib-tool-py] Default values for some other variables


From: Bruno Haible
Subject: Re: [gnulib-tool-py] Default values for some other variables
Date: Tue, 08 May 2012 01:26:32 +0200
User-agent: KMail/4.7.4 (Linux/3.1.10-1.9-desktop; KDE/4.7.4; x86_64; ; )

Hi Dmitriy,

> I think there is a need to create method run(self, mode),
> which will run GNULibImport in the selected mode, because actions are
> different for different modes, while local class variables are the same. Or
> we can create three classes for --import, --add-import, --remove-import,
> which inherit GNULibImport class (so we may have to rename it, e.g. to
> GNULibImporter to emphasize that this module is common for those three
> modules). What do you think?

I think it's more or less a matter of style. Intuitively I would say that
the difference between the 4 modes --import, --add-import, --remove-import,
--update is so small that 5 classes (one for the abstract superclass and
then one for each option) is overkill. Just my personal preference.

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]