[gnugo-devel] doc update and warnings fixed

[Gunnar Farnebäck]

This patch makes some minor doc updates and fixes a couple of warnings
on non-gcc compilers.

/Gunnar

Index: TODO
===================================================================
RCS file: /cvsroot/gnugo/gnugo/TODO,v
retrieving revision 1.16.2.1
diff -u -r1.16.2.1 TODO
--- TODO        29 Aug 2004 02:37:48 -0000      1.16.2.1
+++ TODO        29 Aug 2004 03:20:11 -0000
@@ -12,8 +12,9 @@
 version without signing such a disclaimer. If you want your changes to
 the program to be incorporated into the version we distribute we need
 such a disclaimer. Please contact the GNU Go maintainers, Daniel Bump
-(address@hidden) and Gunnar Farneback (address@hidden), to
-get more information and the papers to sign.
+(address@hidden) and Gunnar Farneback
+(address@hidden), to get more information and the papers to
+sign.
 
 Below is a list of things YOU could work on. We are already working on
 some of these tasks, but don't let that stop you. Please contact us or
Index: doc/install.texi
===================================================================
RCS file: /cvsroot/gnugo/gnugo/doc/install.texi,v
retrieving revision 1.15
diff -u -r1.15 install.texi
--- doc/install.texi    20 Aug 2004 10:30:12 -0000      1.15
+++ doc/install.texi    29 Aug 2004 03:20:11 -0000
@@ -175,7 +175,6 @@
 @command{autoconf}. For example we find in @file{config.h}
 
 @example
-/* Experimental pattern based reading. Disabled by default. */
 /* GAIN/LOSS codes. Disabled by default. */
 #define EXPERIMENTAL_OWL_EXT 0
 
@@ -219,19 +218,14 @@
 @item @code{cosmic-gnugo}. An experimental style which plays a center
 oriented game and has a good winning rate against standard GNU Go,
 though it may not be stronger than standard GNU Go against other
-opponents. This experimental option is a configure option only and
-is not available as a run-time option.
+opponents.
 @item @code{owl-threats}. Compute owl threats. Potentially this could
 makes GNU Go stronger but it also makes the program slower. Moreover the
 owl threat code has not been tested recently and may need some work.
address@hidden @code{experimental-influence}. Use the experimental influence
-module. @strong{Enabled by default.}
address@hidden @code{experimental-semeai}. Use the reading semeai module based 
on
-the owl code. @strong{Enabled by default}.
 @item @code{experimental-connections}. Use the experimental connection
-analysis. @strong{Enabled by default.}
address@hidden @code{alternate-connections}. Use in conjunction with
address@hidden Uses an alternative implementation of
+analysis. @strong{Enabled by default.} Turning it off currently makes
+no difference.
address@hidden @code{alternate-connections}. Uses an alternative implementation 
of
 the experimental connection analysis. @strong{Enabled by default.}
 @end itemize
 
Index: doc/introduction.texi
===================================================================
RCS file: /cvsroot/gnugo/gnugo/doc/introduction.texi,v
retrieving revision 1.22
diff -u -r1.22 introduction.texi
--- doc/introduction.texi       20 Aug 2004 10:30:12 -0000      1.22
+++ doc/introduction.texi       29 Aug 2004 03:20:11 -0000
@@ -156,8 +156,8 @@
 version we distribute we need you to assign the copyright.
 
 Please contact the GNU Go maintainers, Daniel Bump
-(@email{bump@@math.stanford.edu}) and Gunnar Farneb@"ack
-(@email{gf@@isy.liu.se}), to get more information and the
+(@email{bump@@sporadic.stanford.edu}) and Gunnar Farneb@"ack
+(@email{gunnar@@lysator.liu.se}), to get more information and the
 papers to sign.
 
 Below is a list of things YOU could work on. We are already working on
@@ -213,15 +213,11 @@
 contrast to the dragon array where all the data is stored once for every
 intersection of the board.  Complete the conversion of eye_data,
 half_eye_data, worm and dragon to use the same structure as the dragon2 array.
address@hidden Implement persistent caching in the semeai code. 
 @item Support for ko in eyes.db and optics.c.
 @item Integrate the time handling code in play_gtp.c with the autolevel
 code in @file{clock.c}. Alternatively, replace them both with something
 better. Basing it on some solid system identification theory and/or
 control theory wouldn't hurt.
address@hidden Create a paradigm for handling other types of ko (approach move 
ko,
-multi-step ko, etc) and then write code that handles them. 
-(Difficult!)
 @item Write a script which plays through the joseki databases and checks
 that the engine really generates a joseki move for all positions in
 the databases. This would also be interesting to run with the
@@ -320,18 +316,12 @@
 machine.
 @item Making the engine use many machines loosely connected on the
 internet or in a cluster.
address@hidden Think on the opponents time.
address@hidden Think on the opponent's time.
 @item A global alpha-beta reader.  
 @quotation
 This would probably be very slow and could only read 2 or 3 moves ahead.
 Still it could find fatal errors and improve the moves that GNU Go makes.
 @end quotation
address@hidden A pattern based tactical reader instead of the hard coded one.
address@hidden
-This could be made stronger than the current by taking into account
-more moves.  The challenge is to keep it on focus so that the
-reading does not take forever.
address@hidden quotation
 @item 
 @quotation
 A strategic module that identifies high-level goals and then gives
@@ -357,13 +347,18 @@
 To be really useful this would have to deal with early endgame
 positions.
 @end quotation
address@hidden automated fuseki tuning 
address@hidden Automated fuseki tuning 
 @quotation
 Fuseki tuning by hand is difficult. I'd like to encourage people who
 are interested in doing machine learning experiments with GNU Go
 work with the fuseki. This may be one of the areas with most
 potential for substantial and reasonably quick improvements.
 @end quotation
address@hidden More elaborate classification of ko
address@hidden
+Create a paradigm for handling other types of ko (approach move ko,
+multi-step ko, etc) and then write code that handles them.
address@hidden quotation
 @end itemize
 
 
Index: engine/board.h
===================================================================
RCS file: /cvsroot/gnugo/gnugo/engine/board.h,v
retrieving revision 1.13.2.1
diff -u -r1.13.2.1 board.h
--- engine/board.h      29 Aug 2004 02:31:38 -0000      1.13.2.1
+++ engine/board.h      29 Aug 2004 03:20:11 -0000
@@ -181,7 +181,7 @@
 extern float        komi;
 extern int          movenum;      /* movenumber - used for debug output */
                    
-extern Intersection shadow[BOARDMAX];      /* reading tree shadow */
+extern char         shadow[BOARDMAX];      /* reading tree shadow */
 
 extern int chinese_rules;
 extern int allow_suicide;
Index: engine/boardlib.c
===================================================================
RCS file: /cvsroot/gnugo/gnugo/engine/boardlib.c,v
retrieving revision 1.4
diff -u -r1.4 boardlib.c
--- engine/boardlib.c   27 May 2004 00:08:46 -0000      1.4
+++ engine/boardlib.c   29 Aug 2004 03:20:11 -0000
@@ -46,7 +46,7 @@
 int allow_suicide = 0;  /* allow opponent to make suicide moves */
 
 
-Intersection shadow[BOARDMAX];
+char shadow[BOARDMAX];
 
 /* Hashing of positions. */
 Hash_data board_hash;
Index: engine/genmove.c
===================================================================
RCS file: /cvsroot/gnugo/gnugo/engine/genmove.c,v
retrieving revision 1.93.2.1
diff -u -r1.93.2.1 genmove.c
--- engine/genmove.c    29 Aug 2004 02:31:38 -0000      1.93.2.1
+++ engine/genmove.c    29 Aug 2004 03:20:11 -0000
@@ -745,7 +745,8 @@
  * Mirror breaking moves in other situations are handled by patterns
  * in patterns.db.
  */
-static void break_mirror_go(int color)
+static void
+break_mirror_go(int color)
 {
   int tengen = POS((board_size - 1) / 2, (board_size - 1) / 2);
   if (board[tengen] == EMPTY
Index: engine/persistent.c
===================================================================
RCS file: /cvsroot/gnugo/gnugo/engine/persistent.c,v
retrieving revision 1.26
diff -u -r1.26 persistent.c
--- engine/persistent.c 14 Aug 2004 11:30:26 -0000      1.26
+++ engine/persistent.c 29 Aug 2004 03:20:11 -0000
@@ -595,7 +595,7 @@
 compute_active_reading_area(struct persistent_cache_entry *entry,
                            const char goal[BOARDMAX], int dummy)
 {
-  char active[BOARDMAX];
+  signed char active[BOARDMAX];
   int pos, r;
   UNUSED(dummy);
 
@@ -607,7 +607,7 @@
   for (pos = BOARDMIN; pos < BOARDMAX; pos++)
     active[pos] = goal[pos];
 
-  mark_string(entry->apos, active, 1);
+  signed_mark_string(entry->apos, active, 1);
 
   /* To be safe, also add the successful move. */
   if (entry->result != 0 && entry->move != 0)
@@ -624,7 +624,7 @@
        || (ON_BOARD(NORTH(pos)) && active[NORTH(pos)] == 1)
        || (ON_BOARD(EAST(pos)) && active[EAST(pos)] == 1)) {
       if (IS_STONE(board[pos]))
-       mark_string(pos, active, 2);
+       signed_mark_string(pos, active, 2);
       else
        active[pos] = 2;
     }
@@ -811,7 +811,7 @@
 {
   int pos;
   int k, r;
-  char active[BOARDMAX];
+  signed char active[BOARDMAX];
   int other = OTHER_COLOR(board[entry->apos]);
   UNUSED(dummy);
 
@@ -959,7 +959,7 @@
 {
   int pos;
   int k, r;
-  char active[BOARDMAX];
+  signed char active[BOARDMAX];
   int other = OTHER_COLOR(board[entry->apos]);
   UNUSED(dummy);
 
Index: engine/reading.c
===================================================================
RCS file: /cvsroot/gnugo/gnugo/engine/reading.c,v
retrieving revision 1.151.2.1
diff -u -r1.151.2.1 reading.c
--- engine/reading.c    29 Aug 2004 02:36:37 -0000      1.151.2.1
+++ engine/reading.c    29 Aug 2004 03:20:12 -0000
@@ -1239,7 +1239,12 @@
   int j, k, l;
   int goal_liberties = (stackp < fourlib_depth ? 5 : 4);
   int adj, adjs[MAXCHAIN];
-  static unsigned liberty_mark = -1;
+
+  /* We would like to initialize liberty_mark to -1, but some
+   * compilers warn, quite correctly, that -1 is not an unsigned
+   * number.
+   */
+  static unsigned liberty_mark = ~0U;
   static unsigned lm[BOARDMAX];
 
   ASSERT1(libs != NULL, str);
Index: patterns/mkpat.c
===================================================================
RCS file: /cvsroot/gnugo/gnugo/patterns/mkpat.c,v
retrieving revision 1.137.2.2
diff -u -r1.137.2.2 mkpat.c
--- patterns/mkpat.c    29 Aug 2004 02:31:38 -0000      1.137.2.2
+++ patterns/mkpat.c    29 Aug 2004 03:20:14 -0000
@@ -2785,7 +2785,7 @@
 
       if (attributes_needed) {
        fprintf(outfile, "attributes+%d,",
-               p->attributes ? p->attributes - attributes : 0);
+               (int) (p->attributes ? p->attributes - attributes : 0));
       }
       else
        fprintf(outfile, "NULL,");
@@ -2842,7 +2842,7 @@
 
     if (attributes_needed) {
       fprintf(outfile, "attributes+%d,",
-             p->attributes ? p->attributes - attributes : 0);
+             (int) (p->attributes ? p->attributes - attributes : 0));
     }
     else
       fprintf(outfile, "NULL,");