[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Ok I am stupid

From: Markus Plail
Subject: Re: Ok I am stupid
Date: Mon, 12 Aug 2002 07:29:51 +0200
User-agent: Gnus/5.090007 (Oort Gnus v0.07) Emacs/21.3.50 (i686-pc-linux-gnu)

Hi Pawel!

* Pawel Kot writes:

> The problem is with ugly gdat usage in xgnokii_lowlevel.c. It is declared
> as global static. It is nulled in the initializing function which is
> correct. But later in (almost) each function we do:
> void some_function(something)
> {
>       GSM_SomeField_in_GSM_Data something;

>       gdat.something = &something;
>       [...]
>       return;
> }
> After leaving this function the pointer is bogus. Quick fix would be to
> null GSM_Data pointers before quitting the function. The correct fix
> should start with the removal of the global gdat.

The reason for the global gdat was that I needed it for SMS stuff. I
will change that possibly today or tomorrow.

> PS. Why is GSM_Bitmap used with phonebook? Markus?

That's because of caller group pictures.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]