Re: gnokii 0.4.0pre18 is out

[Pavel Machek]

Hi!

> > > Pawel has uploaded the 0.4.0pre18 tarball. You can download it from:
> > > 
> > >     http://freesoftware.fsf.org/download/gnokii/ 
> > > 
> > > The most important change is the sms sending crash bug which was 
> > > introduced
> > > in 0.4.0pre17. Lot of bugfixes and improved portability. It should compile
> > > on Solaris and FreeBSD platform.
> > 
> > Perhaps its time to make it 0.4.0? [Well, after tcp.h is added, obviously.] 
> 
> Just after SMS reaches 0.3.x functionality. Ie.: bitmaps and ringtones will 
> work. Other SMS issues can wait. xgnokii seems to be quite use fur (thanks
> to Markus). When it will happen? I'm quite sure this month yet.

Well, this fixes operator logo sending for me:

I'm not really sure if it is okay or not (obviously printfs need to
die, but is it okay to get length from UserData[0] like that?

                                                                Pavel

Index: common/gsm-sms.c
===================================================================
RCS file: /cvsroot/gnokii/gnokii/common/gsm-sms.c,v
retrieving revision 1.54
diff -u -u -r1.54 gsm-sms.c
--- common/gsm-sms.c    22 Apr 2002 20:16:37 -0000      1.54
+++ common/gsm-sms.c    23 Apr 2002 21:47:20 -0000
@@ -679,16 +683,20 @@
 
        /* User Data Header - if present */
        for (i = 0; i < SMS->UDH_No; i++) {
+               printf("Adding user data headers...\n");
                error = EncodeUDH(SMS->UDH[i], SMS, message + llayout.UserData);
                if (SMS->UDH[i].Type == SMS_MultipartMessage) mm = 1;
                if (error != GE_NONE) return error;
        }
-       SMS->UDH_Length = 0;
+       SMS->UDH_Length = (message + llayout.UserData)[0];
+       if (SMS->UDH_Length)
+               SMS->UDH_Length++;
+       printf("UDH_Length = %d\n", SMS->UDH_Length);
 
        /* User Data */
        EncodeData(SMS, message + llayout.DataCodingScheme, message + 
llayout.UserData + SMS->UDH_Length, mm, &clen);
-       message[llayout.Length] = SMS->Length;
-       *length = clen + llayout.UserData;
+       message[llayout.Length] = SMS->Length + SMS->UDH_Length;
+       *length = clen + llayout.UserData + SMS->UDH_Length;
        return GE_NONE;
 }
 

-- 
(about SSSCA) "I don't say this lightly.  However, I really think that the U.S.
no longer is classifiable as a democracy, but rather as a plutocracy." --hpa