[Gnash-dev] Re: Does loop_test pass there?

[zou lunkai]

Oh, strk has already updated the tag_loaders.cpp.  loop_test  passes
now.  It failed here before just because I did not full update my
sources. sorry.


Oh,  loop_test  fails here
On 12/29/06, zou lunkai <address@hidden> wrote:
> Does loop_test pass there?  It still fails here.
>
> I intended to patch like this, not full tested.
>
> //in file tag_loaders.cpp
> void execute(sprite_instance* m)
> {
>  //*change*, add this
>  character * ch = m->get_character_at_depth(m_depth);
>
>  switch (m_place_type)
>  {
>    case PLACE:  //[1]
>   //*change*, check first and then add
>   if(!ch)  m->add_display_object(...);
>   break;
>   ...
>   ...
>  }
>
> }
> or set the "replace_if_depth_is_occupied" to false in function
> "add_display_object()".
>
> [1]Since the given depth has already been occupied, then we should not
> add another object to this depth. I have seen that
> "add_display_object" has internally change a "PLACE" command to a
> "MOVE"  in this context. Is that correct? I think we should not even
> "MOVE" it, just return, and that fix loop_test for me.