gnash-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnash-dev] CommonGetUrl behaviour.


From: strk
Subject: [Gnash-dev] CommonGetUrl behaviour.
Date: Mon, 18 Sep 2006 10:04:26 +0200

[moved discussion to gnash-dev for broader audience, please keep it here]

On Mon, Sep 18, 2006 at 12:01:38PM +0400, Vitaly Alexeev wrote:
> strk <address@hidden> wrote:   The patch you applied doesn't modify code for 
> loadMovie() but for
> getURL. I don't think load of an external movie is what we need here
> except (maybe) if the Method has value = 64.
> See https://savannah.gnu.org/bugs/?17616
> 
> I suggest we add a list of testcases URLs inside comments of that
> CommonGetUrl function so for every change we can test them all before
> committing.
> 
> --strk;
> 
> 
> Hi,
>   I have made it so because loadMovie("test.swf", _root) should change  
> current root movie on test.swf in the same window. And loadMovie("test.swf", 
> _root.clip) should change  child movieclip "_root.clip" on test.swf.

loadMovie should *not* be handled by the CommonGetUrl function.
CommonGetUrl is only meant for GetUrl and GetUrl2 SWF tag handling.

--strk;

>   I agree with 
>   "
>   I suggest we add a list of testcases URLs inside comments of that
> CommonGetUrl function so for every change we can test them all before
> committing."
> 
>    
>   Vitaly




reply via email to

[Prev in Thread] Current Thread [Next in Thread]