[Gnash-dev] [PATCH] remove some server/ include files in libbase/

[Patrice Dumas]

Hello,

While trying to understand what happens with the missing symbol from 
libbase, I tried to remove any include in libbase to files in server
with the idea that the libbase header files shouldn't depend on the 
server headers but that it should be the other way around.

I have found that the following references cannot be commented
out without a build failure. I am pretty sure this is a bug, I guess
this comes from the fact that this code is experimental and not used,
and the error experienced in make check in libamf will certainly
be fixed if it is fixed:

* network.h (in experimental code):
#include "impl.h"
* network.cpp (in experimental code):
#include "fn_call.h"

I could comment out the remaining without any build error:

* network.h:
#include "xml.h"
* network.cpp:
#include "xml.h"
* log.cpp:
#include "gnash.h"

I attach the patch that comment out those includes.

I think that once the remaining issues in experimental code in libbase 
are fixed, the line

        -I$(top_srcdir)/server\

should be removed from libbase/Makefile.am.

--
Pat

libbase-remove-includes.diff
Description: Text document