[Gnash-commit] [patch #9264] Patch to implement player FSCommand call via `MovieClip.getURL()`

[Nutchanon Wetchasit]

Follow-up Comment #2, patch #9264 (project gnash):

Patch 2 of 2.
See the attached `0002_movieclip-geturl-add-fscommand-tests.patch`.

This patch adds following tests to Gnash testsuite:

* MakeSWF-based test SWF, issuing non-predefined FSCommand from timeline
ActionScript via `MovieClip.getURL()`, with various kind of command name and
parameters.
* Automatic shell-based container emulation tests (with external termination)
for checking SWF's FSCommand execution.
* Semi-automatic JavaScript-based tests in HTML container for checking SWF's
FSCommand execution in real browser environment and proprietary player.

These checks (both shell-based and JavaScript-based ones) run on SWF version 5
to 8, since `MovieClip.getURL()` is available on Flash 5 onward.

Notes:

* The test contain XFAILED cases on...
** `undefined` FSCommand parameter passing: Flash passes "", but Gnash passes
"undefined".
** "<>" string FSCommand parameter passing: Flash correctly passes "<>", but
libgnashplugin won't even call the function (fault of Gnash-libgnashplugin
protocol).
* I used non-predefined (i.e. external) FSCommand, as it is easier to check
the FSCommand call and parameter from container's side; in contrast to
predefined/internal ones, which likely require a full-blown movierunner-based
test to verify result.
* I created a new test instead of integrating these checks into the existing
`extcomm` test
<https://git.savannah.gnu.org/cgit/gnash.git/tree/testsuite/misc-mtasc.all/extcomm.as?id=e9eb84e128f7f0ba4558d00cf794027bf9125a7d>,
to avoid giving a false impression that the associated HTML test runner is
able to run ExternalInterface checks.
* For the record: the `fscommand()` directive is available since Flash 3.

Gnash: 0.8.11dev (patched against git e9eb84e 19-Feb-2017)
Flash Player: 11.0.202.491 (NPAPI binary)
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386


(file #39811)
    _______________________________________________________

Additional Item Attachment:

File name: 0002_movieclip-geturl-add-fscommand-tests.patch Size:30 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9264>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/