[Gnash-commit] [patch #9264] Patch to implement player FSCommand call via `MovieClip.getURL()`

[Nutchanon Wetchasit]

URL:
  <http://savannah.gnu.org/patch/?9264>

                 Summary: Patch to implement player FSCommand call via
`MovieClip.getURL()`
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Sun 19 Feb 2017 01:03:00 PM ICT
                Category: ActionScript
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Patch 1 of 2.
See the attached `0001_movieclip-geturl-add-fscommand-scheme.patch`.

Current Gnash handles `FSCommand:` URL scheme in its GETURL instruction
implementation
<https://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/vm/ASHandlers.cpp?id=e90fc76cd653c5ecb481d845ae07c96715412443#n3531>,
but does not do the same in `MovieClip.getURL()` function
<https://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/asobj/MovieClip_as.cpp?id=e90fc76cd653c5ecb481d845ae07c96715412443#n1089>.
This results in ignored container command and weird errors from external
protocol handler <https://savannah.gnu.org/bugs/?46944#comment0> when running
SWF which tries to issue FSCommand from `MovieClip.getURL()`.

This patch adds a special case inside `MovieClip.getURL()` for handling URL
which starts with `FSCommand:` in the same way as current implementation in
GETURL instruction; fixing bug #46944.

Automated tests will follow.

Gnash: 0.8.11dev (patched against git e90fc76 31-Jan-2017)
System: Debian GNU/Linux 7.0 Wheezy i386




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sun 19 Feb 2017 01:03:00 PM ICT  Name:
0001_movieclip-geturl-add-fscommand-scheme.patch  Size: 1kB   By: nachanon
Patch for implementing FSCommand URL scheme in `MovieClip.getURL()`
<http://savannah.gnu.org/patch/download.php?file_id=39786>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9264>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/