Re: [Gnash-commit] OpenVG postponed for a week

[Sandro Santilli]

On Sun, Aug 14, 2011 at 02:31:17PM -0600, Rob Savoye wrote:
> On 08/14/11 14:17, Sandro Santilli wrote:

> > I noticed a new getAveragePixel() in Renderer class for example, moved
> > from MovieTester. Is that related to OpenVG ?
> 
>   No.

Can we drop it then ? 

> > Also, I've noticed a new Renderer::addRenderImage(GnashVaapiImageProxy*)
> > which seems to be Vaapi-specific code for what should be a generic class.
> 
>   Could be, future plans are to refactor the vaapi code to be more
> portable and useful. That's a future task though...

libbase/GnashVaapiImageProxy.h contains what look like plans for that
in an XXX comment. Is that comment yours ?

 class DSOEXPORT GnashVaapiImageProxy
    /* XXX: Should Renderers use boost::shared_ptr<> we could simple
       derive from a GnashImageProxy base that would itself contain a
       shared pointer to the image */

As it looks like Renderer.h _does_ use boost::shared_ptr<> it may be 
worth doing this before the merge.

> > I'd love to know more about your findings here.  What was AGG specific ?
> > Parsed styles or rendering interface for it ?
> 
>   If you look at Renderer_agg_style.h, you'll see a bunch of templates
> and other stuff that goes along with it. Some of that code has agg
> specific function calls in it, but much looks generic. Our OpenGL and
> Cairo renderers don't use the "new AGG Style" either, so I don't think
> it's a big deal.

I probably didn't understand your concern about style handling being AGG
specific then. I guess we'll be able to talk about it when you're back
from your trip.

--strk;

  ()   Free GIS & Flash consultant/developer
  /\   http://strk.keybit.net/services.html