[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-dev
From: |
Werner LEMBERG |
Subject: |
Re: [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-devel Digest, Vol 149, Issue 5 |
Date: |
Sun, 04 Jun 2017 20:27:49 +0200 (CEST) |
>> . Recently, integer overflow run-time checking was activated
>> (again) for the fuzzer, causing a lot of minor code changes while
>> applying fixes. [...]
>
> I have been following those new OVERFLOW_* macros... they are a bit
> ugly and mostly purely for suppressing warnings?
Yes and yes. They are ugly, and I wonder whether I should drop the
`OVERFLOW_' part of its names to get `SUB_LONG', `ADD_INT32', etc.
> The other one is "drawing in non-twilight while in prep". (does it
> trash every glyph or get ignored by freetype?).
Uh, oh, I currently don't know what FreeType does in such situations.
Too lazy to check that right now :-)
> But it does seem to offer a convenient way of implementing the last
> two error checkings which FontVal 1.0 does that FontVal 2.x does not
> no yet.
>
> e.g. for your OVERFLOW_ADD_LONG() , if I undef your version locally
> in the truetype module, but define a new one as: [...]
Nice idea!
Werner
- [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-devel Digest, Vol 149, Issue 5, Hin-Tak Leung, 2017/06/04
- Re: [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-devel Digest, Vol 149, Issue 5,
Werner LEMBERG <=
- Re: [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-devel Digest, Vol 149, Issue 5, Alexei Podtelezhnikov, 2017/06/04
- Re: [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-devel Digest, Vol 149, Issue 5, Werner LEMBERG, 2017/06/04
- Re: [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-devel Digest, Vol 149, Issue 5, Alexei Podtelezhnikov, 2017/06/04
- Re: [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-devel Digest, Vol 149, Issue 5, Werner LEMBERG, 2017/06/04
- Re: [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-devel Digest, Vol 149, Issue 5, Markus Trippelsdorf, 2017/06/05
- Re: [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-devel Digest, Vol 149, Issue 5, Werner LEMBERG, 2017/06/06
- Re: [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-devel Digest, Vol 149, Issue 5, Behdad Esfahbod, 2017/06/07
- Re: [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-devel Digest, Vol 149, Issue 5, Werner LEMBERG, 2017/06/07
Re: [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-devel Digest, Vol 149, Issue 5, Alexei Podtelezhnikov, 2017/06/05