Re: [ft-devel] FreeType patches to support amalgamation

[Werner LEMBERG]

Hello Vinnie!


Thanks a lot for your work.  I only have a single comment; everything
else looks fine.

In file `4.patch':

> -#define RAS_ARGS       /* void */
> -#define RAS_ARG        /* void */
> +#define black_RAS_ARGS       /* void */
> +#define black_RAS_ARG        /* void */
>  
> -#define RAS_VARS       /* void */
> -#define RAS_VAR        /* void */
> +#define black_RAS_VARS       /* void */
> +#define black_RAS_VAR        /* void */

I think this is a bad change since it unnecessarily uglifies the
source.  It should be fully sufficient to have

  #undef RAS_ARGS
  #undef RAS_ARG
  #undef RAS_VARS
  #undef RAS_VAR

  #define RAS_ARGS  black_PWorker  worker,
  #define RAS_ARG   black_PWorker  worker
  #define RAS_VARS  worker,
  #define RAS_VAR   worker

(and similar code for `gray') as you've done elsewhere too.

Am I missing something?  Otherwise please redo this patch.


    Werner