Re: log-view-minor-wrap

[Stefan Monnier]

>>> With the latest change in log-view.el, typing `=' on a revision in the
>>> *cvs-info* shows the reverse diff.  That's because the first argument of
>>> cvs-diff functions should be the revision at the next older revision,
>>> and the second argument should be the revision at point.
>> 
>> But without this latest change, cvs-mode-edit-log is broken, and so is
>> cvs-mode-find-file and a few more.

> If argument order depends on the function name, then perhaps the
> wrapper function should have an additional argument `-cvs-mode!-fun'?

It's just that the protocol of the cvs-minor-wrap-function is that it
provides 0, 1, or 2 revisions where the first one is the one at point (if
applicable) so that both functions that need 1 arg and functions that need
2 can be used with it.

Your patch also made it impossible to get a diff between 1.65 and 1.4,
forcing you to get a diff between 1.4 and 1.65 instead.  Maybe that's good,
I don't know.  But if you indeed want this behavior, then maybe you should
do it in cvs-mode-diff.


        Stefan