[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps
From: |
Gustav Wikström |
Subject: |
Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps |
Date: |
Wed, 25 Nov 2015 15:39:18 +0000 |
Hi,
Taking your comments and improving the first patch a bit resulted in the
attached one. It replaces the previous. Using string-prefix-p and
string-suffix-p solves the out of index problem in the substrings.
BR
Gustav
> -----Original Message-----
> From: Nicolas Goaziou [mailto:address@hidden
> Sent: Wednesday, November 25, 2015 15:53
> To: Gustav Wikström <address@hidden>
> Cc: address@hidden; sgeorgii . <address@hidden>
> Subject: Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and
> regexps
>
> Gustav Wikström <address@hidden> writes:
>
> > Hmm, since the error was thrown when trying to look at indexes outside
> > of the string in (substring ... ), I don't see how isregexp can be
> > left as is. We have to make sure the substring-code is not evaluated
> > if the tag is empty. What am I missing?
>
> Nothing, I was clear as mud.
>
> (cond
> ((string= "" tag) (setq f1 '(not tags)))
> ((and (equal "{" ...)
> (equal "}"...))
> ...)
> (t ...))
>
> Or even
>
> ((and (string-prefix-p "{" ...)
> (string-suffix-p "}" ...)))
>
> on master.
>
> Regards,
0001-org-agenda-Filter-empty-tags.patch
Description: 0001-org-agenda-Filter-empty-tags.patch
- [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps, sgeorgii ., 2015/11/25
- Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps, Gustav Wikström, 2015/11/25
- Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps, sgeorgii ., 2015/11/25
- Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps, Gustav Wikström, 2015/11/25
- Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps, Nicolas Goaziou, 2015/11/25
- Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps, Gustav Wikström, 2015/11/25
- Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps, Nicolas Goaziou, 2015/11/25
- Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps,
Gustav Wikström <=
- Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps, sgeorgii ., 2015/11/26
- Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps, Nicolas Goaziou, 2015/11/26
- Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps, Gustav Wikström, 2015/11/26
- Re: [O] [RFC] [PATCH] Changes to Tag groups - allow nesting and regexps, Nicolas Goaziou, 2015/11/26