[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] feature/jsx 91c29fb 09/19: Update expectations for JSX ind
From: |
Marcin Borkowski |
Subject: |
[Emacs-diffs] feature/jsx 91c29fb 09/19: Update expectations for JSX indentation in JSXAttribute space |
Date: |
Wed, 27 Mar 2019 05:35:01 -0400 (EDT) |
branch: feature/jsx
commit 91c29fbce170fe34cd3193676f250ea58e0a8056
Author: Jackson Ray Hamilton <address@hidden>
Commit: Marcin Borkowski <address@hidden>
Update expectations for JSX indentation in JSXAttribute space
* test/manual/indent/js-jsx.js: Align expectations for dangling
closing constructs with other places in the tests.
---
test/manual/indent/js-jsx.js | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/test/manual/indent/js-jsx.js b/test/manual/indent/js-jsx.js
index af3c340..2ec00c6 100644
--- a/test/manual/indent/js-jsx.js
+++ b/test/manual/indent/js-jsx.js
@@ -37,7 +37,7 @@ return (
React.render(
<input
- />,
+ />,
{
a: 1
}
@@ -242,12 +242,18 @@ export default ({ stars }) => (
// JS expressions should not break indentation
// (https://github.com/mooz/js2-mode/issues/462).
+//
+// In the referenced issue, the user actually wanted indentation which
+// was simply different than Emacs’ SGML attribute indentation.
+// Nevertheless, his issue highlighted our inability to properly
+// indent code with JSX inside JSXExpressionContainers inside JSX.
return (
<Router>
<Bar>
- <Route exact path="/foo" render={() => (
- <div>nothing</div>
- )} />
+ <Route exact path="/foo"
+ render={() => (
+ <div>nothing</div>
+ )} />
<Route exact path="/bar" />
</Bar>
</Router>
- [Emacs-diffs] branch feature/jsx created (now acab35c), Marcin Borkowski, 2019/03/27
- [Emacs-diffs] feature/jsx 24fcdad 03/19: Add new (failing) unclosed JSX test and separate such tests, Marcin Borkowski, 2019/03/27
- [Emacs-diffs] feature/jsx 754f826 01/19: Add failing tests for JSX indentation bugs, Marcin Borkowski, 2019/03/27
- [Emacs-diffs] feature/jsx 91c29fb 09/19: Update expectations for JSX indentation in JSXAttribute space,
Marcin Borkowski <=
- [Emacs-diffs] feature/jsx 539191c 07/19: Font-lock JSX while editing it by extending regions, Marcin Borkowski, 2019/03/27
- [Emacs-diffs] feature/jsx 79954c6 05/19: Use js-jsx- prefix for functions and variables, Marcin Borkowski, 2019/03/27
- [Emacs-diffs] feature/jsx acab35c 19/19: Add tests for miscellaneous JSX parsing feats, Marcin Borkowski, 2019/03/27
- [Emacs-diffs] feature/jsx e196207 15/19: Indent broken arrow function bodies as an N+1th arg, Marcin Borkowski, 2019/03/27
- [Emacs-diffs] feature/jsx 071c134 06/19: Add basic JSX font-locking, Marcin Borkowski, 2019/03/27
- [Emacs-diffs] feature/jsx ec144e9 12/19: Automatically detect JSX in JavaScript files, Marcin Borkowski, 2019/03/27
- [Emacs-diffs] feature/jsx c66bfa6 10/19: Indent JSX as parsed in a JS context, Marcin Borkowski, 2019/03/27
- [Emacs-diffs] feature/jsx f7ac5e4 11/19: Finish replacing SGML-based JSX detection with js-mode’s parsing, Marcin Borkowski, 2019/03/27
- [Emacs-diffs] feature/jsx 79118f8 16/19: Fix counting of nested self-closing JSXOpeningElements, Marcin Borkowski, 2019/03/27
- [Emacs-diffs] feature/jsx 4337acd 14/19: Rename tests to use the “.jsx” file extension, Marcin Borkowski, 2019/03/27