[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] feature/jsx 24fcdad 03/19: Add new (failing) unclosed JSX
From: |
Marcin Borkowski |
Subject: |
[Emacs-diffs] feature/jsx 24fcdad 03/19: Add new (failing) unclosed JSX test and separate such tests |
Date: |
Wed, 27 Mar 2019 05:35:00 -0400 (EDT) |
branch: feature/jsx
commit 24fcdad9c4cf354fcef9507dbb5a6320cc5e7c22
Author: Jackson Ray Hamilton <address@hidden>
Commit: Marcin Borkowski <address@hidden>
Add new (failing) unclosed JSX test and separate such tests
* test/manual/indent/js-jsx.js: Move test with intentional scan error to
its own file, js-jsx-unclosed-1.js.
* test/manual/indent/js-jsx-unclosed-1.js: New file.
* test/manual/indent/js-jsx-unclosed-2.js: New file with test for
regression caused by new ambiguous parsing of JS/JSX.
---
test/manual/indent/js-jsx-unclosed-1.js | 15 +++++++++++++++
test/manual/indent/js-jsx-unclosed-2.js | 17 +++++++++++++++++
test/manual/indent/js-jsx.js | 9 ---------
3 files changed, 32 insertions(+), 9 deletions(-)
diff --git a/test/manual/indent/js-jsx-unclosed-1.js
b/test/manual/indent/js-jsx-unclosed-1.js
new file mode 100644
index 0000000..9418aed
--- /dev/null
+++ b/test/manual/indent/js-jsx-unclosed-1.js
@@ -0,0 +1,15 @@
+// -*- mode: js-jsx; -*-
+
+// Local Variables:
+// indent-tabs-mode: nil
+// js-indent-level: 2
+// End:
+
+// The following test goes below any comments to avoid including
+// misindented comments among the erroring lines.
+
+return (
+ <div>
+ {array.map(function () {
+ return {
+ a: 1
diff --git a/test/manual/indent/js-jsx-unclosed-2.js
b/test/manual/indent/js-jsx-unclosed-2.js
new file mode 100644
index 0000000..2d42cf7
--- /dev/null
+++ b/test/manual/indent/js-jsx-unclosed-2.js
@@ -0,0 +1,17 @@
+// -*- mode: js-jsx; -*-
+
+// Local Variables:
+// indent-tabs-mode: nil
+// js-indent-level: 2
+// End:
+
+// The following tests go below any comments to avoid including
+// misindented comments among the erroring lines.
+
+// Don’t misinterpret equality operators as JSX.
+for (; i < length;) void 0
+if (foo > bar) void 0
+
+// Don’t even misinterpret unary operators as JSX.
+if (foo < await bar) void 0
+while (await foo > bar) void 0
diff --git a/test/manual/indent/js-jsx.js b/test/manual/indent/js-jsx.js
index 35ca4b2..af3c340 100644
--- a/test/manual/indent/js-jsx.js
+++ b/test/manual/indent/js-jsx.js
@@ -257,12 +257,3 @@ return (
// indent-tabs-mode: nil
// js-indent-level: 2
// End:
-
-// The following test has intentionally unclosed elements and should
-// be placed below all other tests to prevent awkward indentation.
-
-return (
- <div>
- {array.map(function () {
- return {
- a: 1
- [Emacs-diffs] branch feature/jsx created (now acab35c), Marcin Borkowski, 2019/03/27
- [Emacs-diffs] feature/jsx 24fcdad 03/19: Add new (failing) unclosed JSX test and separate such tests,
Marcin Borkowski <=
- [Emacs-diffs] feature/jsx 754f826 01/19: Add failing tests for JSX indentation bugs, Marcin Borkowski, 2019/03/27
- [Emacs-diffs] feature/jsx 91c29fb 09/19: Update expectations for JSX indentation in JSXAttribute space, Marcin Borkowski, 2019/03/27
- [Emacs-diffs] feature/jsx 539191c 07/19: Font-lock JSX while editing it by extending regions, Marcin Borkowski, 2019/03/27
- [Emacs-diffs] feature/jsx 79954c6 05/19: Use js-jsx- prefix for functions and variables, Marcin Borkowski, 2019/03/27
- [Emacs-diffs] feature/jsx acab35c 19/19: Add tests for miscellaneous JSX parsing feats, Marcin Borkowski, 2019/03/27
- [Emacs-diffs] feature/jsx e196207 15/19: Indent broken arrow function bodies as an N+1th arg, Marcin Borkowski, 2019/03/27
- [Emacs-diffs] feature/jsx 071c134 06/19: Add basic JSX font-locking, Marcin Borkowski, 2019/03/27
- [Emacs-diffs] feature/jsx ec144e9 12/19: Automatically detect JSX in JavaScript files, Marcin Borkowski, 2019/03/27
- [Emacs-diffs] feature/jsx c66bfa6 10/19: Indent JSX as parsed in a JS context, Marcin Borkowski, 2019/03/27
- [Emacs-diffs] feature/jsx f7ac5e4 11/19: Finish replacing SGML-based JSX detection with js-mode’s parsing, Marcin Borkowski, 2019/03/27