[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] /srv/bzr/emacs/trunk r106519: Rename locals to avoid s
|
From: |
Paul Eggert |
|
Subject: |
Re: [Emacs-diffs] /srv/bzr/emacs/trunk r106519: Rename locals to avoid shadowing. |
|
Date: |
Mon, 28 Nov 2011 00:22:35 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 |
On 11/27/11 20:34, Stefan Monnier wrote:
>> > I'd also like to install the following, so that we're consistent about
>> > avoiding the inner_gcpro stuff everywhere in Emacs.
> OK, go ahead, thank you,
Done, as bzr 106537.
> I still haven't seen a bug avoided by warnings about such
> shadowing
In my experience shadowing is more about confusion
than it is about bugs. The confusion makes it harder to
understand the code, and this slows developers down
without necessarily introducing bugs.
It's a minor issue, to be sure.