Re: [Emacs-diffs] /srv/bzr/emacs/trunk r106519: Rename locals to avoid shadowing.

[Stefan Monnier]

>> I specifically refused to install this patch because of the ugliness of
>> this "inner_gcpro" stuff.
> Ah, OK, I undid that change.  I find the shadowing confusing, but
> confusion (like ugliness) is in the eye of the beholder.

This kind of shadowing is not necessarily something to encourage,
indeed, but it's not something that's fundamentally problematic either
(e.g. I still haven't seen a bug avoided by warnings about such
shadowing).

> I'd also like to install the following, so that we're consistent about
> avoiding the inner_gcpro stuff everywhere in Emacs.

OK, go ahead, thank you,


        Stefan